Nicolás Ojeda Bär

Results 260 comments of Nicolás Ojeda Bär

> > Can you restart that particular job? It failed due to an hopefully transient network error. > > I couldn't figure out how to restart that one job, but...

Merged! Thanks @dra27, @shym and everyone else who helped with the hard work!

Would it work to remove the directory part from the install name (ie have the install name be only `libasmrun_shared.so`)?

> The ppxlib fix would be to imitate the compiler by parsing the whole source at once and setting `Location.input_lexbuf`. This would also simplify the ppxlib code by avoiding weird...

Apologies for the delay. > Should I interpret the silence as this is something folks don't want? No, just that there is limited reviewing capacity in the team :) In...

I got bitten by this today; now am looking forward to this patch :)

> not sure if work needs to be done to tweak for `i386`. The native-code compiler does not support i386 anymore, so nothing needs to be done.

Personally, I don't have see any problems with doing so. @gasche, @Octachron: do you see any issue with this proposed addition?

> note that `Val_true` and `Val_false` are a thing in case you want to use them. Indeed, amended as suggested. Thanks.

> I'm not fond of the current API where you expose an API in the runtime that looks OS-agnostic but in fact has weird/nonsensical return values on non-Windows systems. Good...