Nicolás Ojeda Bär

Results 260 comments of Nicolás Ojeda Bär

> * If the user supplied `-I root`, where `root` is the workspace root. This in effect makes the directories supplied by the compiler unnecessary. If this is enough to...

> @nojb, true, if they know to do it. I don't see how passing `-I` to the debugger is in any way different from passing `-I` to the compiler. We...

Meta-comment: thanks a lot for the very useful description of the patch, I learned several things I didn't know from it!

I don't think there is a lot the OCaml compiler can do here (this seems rather an issue with passing the right flags to the system linker). I would suggest...

> * It is no longer necessary to use the preview release of Visual Studio, although it is advisable, as there are atomics-related fixes in 17.9 Just to clarify, if...

> There is an open question for discussion as to whether we would take the step of publishing a release tarball which includes them [the `winpthreads` sources] I would suggest...

> * [ ] shym/winpthreads replaced with ocaml/winpthreads (or another solution) Just to confirm: the reason we can't put this directly in the tree is because of the license? >...

> > Note that, at the moment, a series of patches under review upstream are required for winpthreads to compile cleanly with MSVC. The master branch on [shym/winpthreads](https://github.com/shym/winpthreads) tracks commit...

I ran a precheck and it passed (the mingw64 check failed for what looks like unrelated reasons): https://ci.inria.fr/ocaml/job/precheck/963/ @dra27 @shym anything else left to do?

> Can you restart that particular job? It failed due to an hopefully transient network error. I couldn't figure out how to restart that one job, but I relaunched the...