Nicolás Ojeda Bär

Results 510 comments of Nicolás Ojeda Bär

No, this is not yet supported out-of-the-box. This would be a nice addition and not very hard I think, a nice task for someone wanting to get into `dune`'s codebase....

One issue I can see is that is that `merlin` gets a *command line* to run as a PPX, which is executed via `system()`. But the "fancy" spawn functions that...

> Is that a problem in practice? I'm not sure, but having to quote things always makes me nervous :)

I left a few commets about the Windows stubs there.

> Any reason why you don't simply specify the files as positional arguments like other compilation objects ? (rather than overload `-I`). If we use positional arguments it is a...

> I may be forgetting something but I think it is unambiguous: Yes, I think this makes sense.

> Also, could you add tests? (That `-I` works when given a single file, that positional arguments are interpreted as your last commit suggests, ...) I added a test, thanks.

I think we should not duplicate the extension in the command line flag since it is redundant. What about `-If` (as in "include file") ?

> @nojb what is the status of this PR? I was sort of assuming that it had been merged, Sorry, the PR stalled -- too much on my plate. To...