Florian Verdonck

Results 874 comments of Florian Verdonck

Feel free to push to this branch. Tis probably best to make a new PR for this really.

Hey Freddy, Yeah, that is still a bit of a tricky one. The target can be multiple things (for example `select`) so we can't quite pick a useful type here....

Maybe a helper to get the `.value` as string (option?) would go a long way. That is what 95% of the users will need.

Because `fromNode` would require a runtime check to be safe. Something like `instanceof HTMLInputElement`, that would no longer make it a zero-runtime binding, which is another of discussion. Maybe we...

This is only a problem from a certain point of view. What happens here makes sense to me according to Fantomas' internal rules. Open statements are grouped into an open...

> From the current vote count We need more input before deciding. So far the votes suggest a different option is preferred as the default, but that is relative: Fantomas...

> The parser has to support all three options anyway. This is just about the Fantomas default. "Has to" is a bit of an assumption. The parser mostly supports three...

I'm no lore expert like yourself on this, but I don't quite distill that stroustrup has always been a thing from reading https://fsharp.github.io/fslang-spec/lexical-filtering/#1514-offside-lines I'm happy to be wrong there though.

@lydell thanks a bunch for this example! It is pretty wild that ```fsharp let timeline = [ ticketCreated statusAssigned resolved reopened moreInfoRequested escalated ] |> List.map wrapEvent ``` is invalid...

> How do we feel about such a combination? A new mode is not something we are considering here. You can open a discuss on https://github.com/fsprojects/fantomas/discussions if you like.