Florian Verdonck

Results 874 comments of Florian Verdonck

> thanks, but `npx rescript build --create-sourcedirs` creates an empty .sourcedirs.json: > > `{"dirs":[],"generated":[],"pkgs":[]}` > > while `npx rescript legacy build` actually populates it Yes, I noticed that as well....

Yeah the main rescript repository would be the right place for that. Much appreciated!

Hello, thank you for reporting this issue! The second trivia (`#endif`) is lost because we are merging the two `AttributeListNodes` into a single one. ([sample](https://fsprojects.github.io/fantomas-tools/#/fantomas/main?data=N4KABGBEDGD2AmBTSAuKAdATugdl3ALgJ4AOiYAGmALxgCWOB%2BOAhjvMwPSdgDEdAMzAA5AKIAVAKwB9AAzSA8gCVpAcSWiAguNFLmECAG0APAGUiAZwKIAtgDolAV0Z0biOwGFYNknQA2iJimgQBudNCIFnYAkhZKiCzwCjh%2BRAB8ALpcPLyI7IL6BiYejlbeogCOjix%2BdMQA3CKwXj4smHQWsDiNpgSYjtAEmWAAmjT0jMyQADTgUBaIBAQMAOYWqGCGcxCgBgaQACTEZBuQDAQz2-sHITWOyGhbe3uys8-70ex5BKZ0AF7IN7vMAAFiuEAyVwAvkCduCoEdSA8oOdLu9Drc-PcNk9gQBGWHPSAAWRYAA8ADIMRAUvIrAgACzR%2BIATLJ4ZC9jCrrsiYiTmhIHkkgIqThEL0iAFmXsMXdkbj3izCbLROwFKLqTKiX4BJAOdDCbzZfzkZAAEawWB%2BbUQOVYhXwiAAZhVHxwC0wBAAYgwasJEAB3Wri20GPr3A1co3ww7HM2W61h%2B3Yx5O0Fuu2mEgsCIAIUQAlgmEQAAU2iw3NZMGGIBHEFGDNy9sbrvHTombW6U47gWBJJmoNnc4gC0WSxTYIHAtAWAtPiFYLPll1a2B642IM2DK27aaO1au7GbvKcemAGyDyDD-OF4uIACqJDImFn85wi%2BXdFXg4ENQWm5gNucLovugqdsmJ4OmefYAOxXjeo53iWHh%2BHOFheB6EaDMWa5-n4AHvJyTYxqB7bgYekGYqmmzpgAHAhOa3uOiDErY5qBHh-4NkRho8se5FQBB3ZQTRirPAAnIxI5jveXh%2BD%2B6b4YRzzEVupF8oJFqUSJ1G9virzpteTGIJoAjVi0NgsGuG68dG-FkUiB5Jrpp5pn2eIEkZiGySWwQ2OE1qKX2yk8apfEtgJTkUS5x56TBrLSREZnVv5gUKTgNn9GFexqUBGkmlpwlxW5tEea63kmZomCwM48AACKILUAXVllkZ2SRDmadFKKMFRpXiXseIglepJktEAjiAyeSmAyxYEAA6nQ8CMmu7IdepXWFT1Zx9a50HufiA5GWNE1TXkogERKc1ektK1MoO57reF9mRY5Aq9Rc%2B1iemeKXid5KfAIdBkgoL4sAQxaiGSJAlhYFjfplg50c9uURTuUUfbtX0lQdZX4vBANkvEcCYPAd2rYOIKowYeXAWAu4IlpqLffp7x4gxRMk8W8DCI4NgcZgGrRNYNjrIOeKAfTjNxjtNiOH4ywhog3rFlZSyBOITmswl7NSUZ3Nk8SCtK9SquYOrrVXtADIVoMgTSIGy2rVLBVtjtLO4z9fZsqN5LVZgLBEAomBUlYFMPfRNMQujIHdVjnugfFh1Kl5fYkv7mCB8HocdAQfMC4Ewui%2BLv2u1t7tY-Liv%2BGbasQ9WWsnDrKfPCyypGQHQch2HBDGzXyvm5bnHW7bgf25gjvO0y5dvfHZqJ3yyf40qFXp2NABq8p5gw8CrBHa4o7PGPvQve1e2zbcjUT3rOIMiM7-kOArAfVPR2AdNu3uRU6Rfutt8ddOAZgzUgLAQaceQm6IEasDHAdREaaHYGxQumBS59lsi9Tqc9tpY2KknAa6YWT-XTpoWoKwcC3xwPfLovxyEQ0cCWcQsBPhIEYBDRGXErrHzjjghMv98F40GgYFkhMSGK0CKwZYIQaRdBWMgwWMCGDwK6Gg4EoVuEM0xnw2KAjvbAhZJzdeJs6BihpJWc08AWCoVgAjZ%2BwDlacJUmjV6J957OSPLoy%2BewWT63TtDF8rhvg1AANKIEQCQFh3xPh5kDlQyOIVuIaJlmBIS-Cl4EL7M6Qy6c8xoRwAAa1MRYaqtV2ABisIgeA-dTbin8XDBGKi2o5VprHTRp93H9UEemZ0adgSQDzG0Xy0COjQHaAFSRlSHxwK6I1aAaFA4riRkpRJG18oV2-nLYxysYm5nyYsSU0oW4r2eM6DuRiB6gPHnsn4xBDlGVGZWMg8B9SrOllo04i8TTLyES6NefTQnhLGgXQWGpclsEKdSVR7NZDv0-uspmO08HpK6Zk6%2BQCgzbOQqxLZ1IWgkEcAQdhXQ6mRAaUs9B2UknvJih45Fej3jOkAX0-xgRAlsL8JdAKFh4lqJWZgrccwMhAjOBYb0CMNjqKhEAA)) It would be safer to...

Great! At first glance, I think an extra check in https://github.com/fsprojects/fantomas/blob/0e925b44d92800bc6017677931988a96138d6f77/src/Fantomas.Core/CodePrinter.fs#L3476 could be relevant. `genOnelinerAttributes` will merge the attributes, which is not what we want in this case.

Hmm, the style guide seems a little incomplete on this topic. The [original issue](https://github.com/dotnet/docs/issues/9070) doesn't mention multiple attributes. And I believe, this is one of those early Fantomas things, which...

Yes, these things can happen as the trivia assignment process is not without its flaws. This is hard to get 100% right, and in an extreme example, there will always...

> Should Oak model which attributes are before and after the leading keyword? Not sure what you are asking here. > Are the Children on Oak node supposed to be...

Yes, I second that the default experience could be better. - Could it not find a package.json in the `cwd`? - Can we skip the required config file? I just...

@cknitt any idea what exactly bsb is checking to figure this out?

This happens here in bsb: https://github.com/rescript-lang/rescript/blob/c092acd0ff979d1a4b2bbf67f7986dbad8940b6d/compiler/bsb/bsb_ninja_regen.ml#L38-L55 We no longer have this file, so I think we need to cook up some new file to store the version. @jfrolich does anything...