Florian Verdonck

Results 874 comments of Florian Verdonck

Currently using the patternhole as found node in frontend completion. Next thing would be for that range to be present in the cmt file.

@jfrolich just try the pkg-pr version of this PR and the setting is not getting picked up. Any idea what I'm missing here?

I'm a bit confused why the other jsx compiler arguments are currently not passed down. But that last commit makes it work for me.

Hmm, I guess we can merge and revisit if passing the other jsx args turns out to be a bad thing.

Hi, thanks for the report. This is one of those things where we add them because it is the safe thing to do to avoid another related problem. I would...

Step one would be to add a new test in `TupleTests.fs`: ```fsharp [] let ``maxime thing`` () = formatSourceString """ func ("/health", fun a b -> "") """ config |>...

Thank you for reporting this! Are you interested in sending a PR for this?

Hello, Thanks for reporting this problem! You would need to extend https://github.com/fsprojects/fantomas/blob/b7dca797317471654fc693ed5a056cfb90bd73d4/src/Fantomas.Core/CodePrinter.fs#L44-L63 with `Expr.AppLongIdentAndSingleParenArg` where you want to check the `FunctionName` I think. Would you be interested in sending a...

You should snatch the original ident text from source code in https://github.com/fsprojects/fantomas/blob/06d86ad91974467f0e82f5f0ca7d3c58eef7e859/src/Fantomas.Core/ASTTransformer.fs#L42 using `creationAide.TextFromSource fallback range`.

Actually, we should reuse the logic of https://github.com/fsprojects/fantomas/blob/06d86ad91974467f0e82f5f0ca7d3c58eef7e859/src/Fantomas.Core/ASTTransformer.fs#L25-L42 instead (`ident.idText.Length + 4 = width`) perhaps.