rescript-compiler icon indicating copy to clipboard operation
rescript-compiler copied to clipboard

Add flag for preserve jsx mode to rescript.json

Open nojaf opened this issue 7 months ago • 1 comments

@jfrolich I tried this after building locally, cargo build --release. Then ../rescript/rewatch/target/release/rewatch in my own project, and this didn't get picked up. Any ideas why?

nojaf avatar Jun 13 '25 06:06 nojaf

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7547
@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7547
@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7547
@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7547
@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7547
@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7547

commit: 040dc5e

pkg-pr-new[bot] avatar Jun 13 '25 15:06 pkg-pr-new[bot]

@jfrolich just try the pkg-pr version of this PR and the setting is not getting picked up. Any idea what I'm missing here?

nojaf avatar Jun 19 '25 14:06 nojaf

I'm a bit confused why the other jsx compiler arguments are currently not passed down. But that last commit makes it work for me.

nojaf avatar Jun 23 '25 08:06 nojaf

Hmm, I guess we can merge and revisit if passing the other jsx args turns out to be a bad thing.

nojaf avatar Jul 01 '25 06:07 nojaf