Florian Verdonck

Results 874 comments of Florian Verdonck

We should similarly replace some of the analysis lsp types with https://opam.ocaml.org/packages/lsp/. This also uses yojson under the hood.

Ah, no I did a a global install of the latest tree-sitter. Could that be it?

All works as before. It is a slight trade-off in terms of transparency. However, I wouldn't underestimate how many devs are used to running the single command to get going....

> 1. How dependent is this solution on the Vite version? E.g., does it still work with Vite 6? Do you think we should update the template to Vite 6...

So, your problem is with building the F# compiler? Might be worth listed the output where things are going wrong.

> Never emitting an empty module is a bit like never emitting an empty list. Not sure if I follow, an empty list could have meaning where an empty module...

@cristianoc do you have any ideas when the `import *` line is constructed? In which phase would that happen? I think tackling it there might be the safer than avoid...

Yes, I'm aware of that, it makes sense why it is there. I'm just wondering, where in the codebase it will organize the imports and how that part works?

Hi, Running this target sets up the git hook: https://github.com/fsharp/FsAutoComplete/blob/e3353360771969be51ab3c84a57a432cf41816cf/build/Program.fs#L107-L110 > dotnet run --project ./build/build.fsproj -- -t EnsureRepoConfig And I think it would be nice to see a message when...

You could investigate in https://github.com/fsprojects/fsharp.Formatting/ why they are not showing up. This could very well be an actual bug.