Florian Verdonck
Florian Verdonck
Thanks a bunch for this feedback. Will circle back to this on Monday. Enjoy the weekend, cheers!
Hi @amunger > If possible, we should also follow the pattern of Worker usage from the other built-in extensions and avoid the node imports e.g. the [css extension](https://github.com/microsoft/vscode/blob/f0417069c62e20f3667506f4b7e53ca0004b4e3e/extensions/css-language-features/client/src/node/cssClientMain.ts#L19) I'm a...
Alright, I believe this is ready for review @amunger.
Thanks for the reviews @amunger and @rebornix!
Hello @rebornix, would you mind reviewing this PR as well? Is this good to go? Let me know if this needs any more tweaks, happy to address these.
Not quite sure why `Pack` is failing, I suspect using `$GITHUB_RUN_ID` is too high a number.
@cknitt I believe this is still an issue. Should it be on the board?
I tried it, and I found it to be quite lackluster and limited.
We could maybe revisit this over at https://github.com/rescript-lang/rescript/, since we move the analysis code over there now. @Mng12345 did this ever work well for you? I found that not all...
Not sure if relevant here, but I still see `1.2.0` for `bunx rewatch --version`. At some point, this should be the rescript version? `rewatch legacy --help` doesn't show any help:...