node

node copied to clipboard

[v21.x] Revert "fs: remove workaround for `esm` package"

6

Fixes: #51081

jeremymeng

readdirSync cannot read files properly when using { recursive: true, withFileTypes: true }

5

### Version v18.17.1 ### Platform _No response_ ### Subsystem fs ### What steps will reproduce the bug? ```shell mkdir -p test/include touch test/libvips-cpp.so.42 ``` ```javascript const fs = require('fs'); fs.readdirSync('test',...

prfd

Enhanced Object Introspection and Help in the Node.js REPL

2

### What is the problem this feature will solve? Node.js developers, especially those coming from a Python background, may find it less intuitive to quickly explore object properties, available methods,...

hemanth

MessageEvent cannot be prevented even if cancelable is true

7

### Version v18.14.2 (the same on LTS v20.11.0) ### Platform Darwin imac.home 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64 ### Subsystem _No response_ ###...

kettanaito

I don't think that the dot reporter is really useful, because in case of failures it does not print the failed tests. Could we make it print the failed tests?

mcollina

doc: fix http.Server upgrade event parameter name

1

The first parameter passed to listeners on an http.Servers upgrade event is the client request. This changes the docs to call that parameter 'request'; before, it was confusingly called 'response'....

jfhr

why is the first argument to an http.Server's upgrade event listener called response?

3

### Affected URL(s) https://nodejs.org/api/http.html#event-upgrade ### Description of the problem The first argument passed to listeners on the `'upgrade'` event on an `http.Server` is called `response` in the docs, even though...

jfhr

childprocess kill() results in -4048 EPERM error on windows since update to v21.6.2

14

### Version v21.6.2 ### Platform Microsoft Windows NT 10.0.22621.0 x64 ### Subsystem child_process ### What steps will reproduce the bug? Suddenly in latest undici the tests in `test/node-test/debug.js` fail if...

Uzlopak

In previous version of this fix, I've simply added a check if the tested tool is available or not. Unfortuntelly, this fails when only the first tool is to be...

AdamMajer

test_runner: improve `--test-name-pattern` to allow matching single test

6

Try to match a test by name prefixed with all its ancestors to ensure uniqueness of the name Fixes: https://github.com/nodejs/node/issues/46728 It adds a feature that is present in all major...

mdrobny