node

node copied to clipboard

Fix an assertion when running dotnev tests with GN build: assertion !empty() failed: string::front(): string is empty which was caused by calling value.front() without verifying the value is not empty.

zcbenz

node:test APIs returning Promises clashes with no-floating-promises lint rule

16

### Version 21.5.0 ### Platform n/a ### Subsystem node:test ### What steps will reproduce the bug? 1. Write code that calls a `describe`, `it`, or `test` function imported from [`node:test`](https://nodejs.org/api/test.html)...

JoshuaKGoldberg

[v18.x] build: fix incorrect g++ warning message

8

The warning message was inadvertently changed to a newer version of g++ than the one being checked for when a refactor PR was [merged to v18.x-staging](https://github.com/nodejs/node/commit/72443bc54bd4253a887620ffa46972e47257d7be#diff-4d5f3192809ec1b9add6b33007e0c50031ad9a0a2f3f55a481b506468824db2cR1058). Refs: https://github.com/nodejs/node/pull/47667 cc @nodejs/lts

richardlau

### Version v20.11.0 ### Platform Darwin Kernel Version 23.2.0 ### Subsystem node:test ### What steps will reproduce the bug? When performing tests that require the mocking of timers, it is...

mscottnelson

Trying to load two modules with the same URL throws an empty object

8

In a loader module I'm handling sources with omitted `type` import attribute on JSON imports, by assigning `context.importAttributes.type` in the load hook, while caching the outputs. When the attributes are...

bpstrngr

Support GN build without using depot_tools

3

The GN build is documented at #51676, which however requires using `depot_tools` from Chromium for building, and the code of Node must be checked out in a specific directory structure....

zcbenz

test_runner: use of `--test-reporter=lcov` throws [ERR_MODULE_NOT_FOUND]

1

### Version v20.9.0, v20.1.0 ### Platform Darwin moon.local 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:31:00 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6020 arm64 ### Subsystem test runner ### What steps will reproduce...

david-luna

`http.server.close()` closes idle connections since 18.19.0

1

### Version 18.19.0 ### Platform Linux, Mac, Windows ### Subsystem _No response_ ### What steps will reproduce the bug? ```javascript import http from 'node:http'; import timers from 'node:timers/promises'; const server...

Llois41

### Version v21.4.0 ### Platform Darwin chug.lan 22.6.0 Darwin Kernel Version 22.6.0: Tue Nov 7 21:42:27 PST 2023; root:xnu-8796.141.3.702.9~2/RELEASE_ARM64_T8103 arm64 ### Subsystem fs ### What steps will reproduce the bug?...

danfuzz

Support snapshotting node:test

3

### Version v20.0.0 ### Platform _No response_ ### Subsystem bootstrap ### What steps will reproduce the bug? ```py $ cat input.js require('node:test') $ lldb -- $(command -v node) --snapshot-blob snapshot.blob...

RaisinTen