node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

tools: make utils.SearchFiles deterministic

Open brjsp opened this issue 1 year ago • 5 comments

glob.glob on Linux returns files in the order returned by the filesystem driver, and the output from this function is stuffed by the Electron build process straight into the config.gypi header, causing non-reproducible builds.

See this log for an example of the nondeterminism: https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out

brjsp avatar Sep 02 '22 18:09 brjsp

CI: https://ci.nodejs.org/job/node-test-pull-request/46393/

nodejs-github-bot avatar Sep 02 '22 18:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46419/

nodejs-github-bot avatar Sep 05 '22 12:09 nodejs-github-bot

@brjsp Would you mind force-pushing the same commit with an amended commit message that adheres to the commit message guidelines?

tniessen avatar Sep 05 '22 12:09 tniessen

@tniessen done

brjsp avatar Sep 05 '22 14:09 brjsp

CI: https://ci.nodejs.org/job/node-test-pull-request/46423/

nodejs-github-bot avatar Sep 05 '22 14:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/47051/

nodejs-github-bot avatar Oct 03 '22 23:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/47065/

nodejs-github-bot avatar Oct 04 '22 13:10 nodejs-github-bot

Landed in e2ca29f673ce413e8090b7ae85a2228eaf421892

nodejs-github-bot avatar Oct 04 '22 15:10 nodejs-github-bot

@sxa the default string comparator in Python sorts by codepoint value, ignoring any locale settings.

brjsp avatar Oct 04 '22 19:10 brjsp