node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

[v14.x backport] deps: update corepack to 0.14.1

Open aduh95 opened this issue 1 year ago • 3 comments

Backport of:

  • https://github.com/nodejs/node/pull/43402
  • https://github.com/nodejs/node/pull/43748
  • https://github.com/nodejs/node/pull/43965
  • https://github.com/nodejs/node/pull/44159
  • https://github.com/nodejs/node/pull/44229
  • https://github.com/nodejs/node/pull/44318
  • https://github.com/nodejs/node/pull/44509
  • https://github.com/nodejs/node/pull/44704

aduh95 avatar Jul 10 '22 14:07 aduh95

FWIW I don't believe the commit queue works for any branch other than main. For one thing when https://github.com/nodejs/node/blob/main/.github/workflows/commit-queue.yml is run on the cron timer I believe github.ref_name is always refs/heads/main so the PR list is always filtered to PR's with a base branch of main. A second blocker would be that the github bot user isn't a backporter so can't land things on the staging branch.

richardlau avatar Jul 25 '22 15:07 richardlau

CI: https://ci.nodejs.org/job/node-test-pull-request/45675/

nodejs-github-bot avatar Jul 25 '22 15:07 nodejs-github-bot

FWIW I don't believe the commit queue works for any branch other than main. For one thing when https://github.com/nodejs/node/blob/main/.github/workflows/commit-queue.yml is run on the cron timer I believe github.ref_name is always refs/heads/main so the PR list is always filtered to PR's with a base branch of main. A second blocker would be that the github bot user isn't a backporter so can't land things on the staging branch.

Got it. Removed the commit-queue label.

F3n67u avatar Jul 25 '22 16:07 F3n67u

Landed in 4f83d75626ee...a1f8e4db48a8

danielleadams avatar Oct 01 '22 14:10 danielleadams