Nodar Chkuaselidze

Results 56 comments of Nodar Chkuaselidze

This will crash on most common use case: `WalletClient` where wallet node runs separately, because WalletClient wont have `node`.

I can split this PR so we can reduce conflict surface for other PRs and merge potentially easy things quicker and wait for other PRs, so I can rebase on...

Even though it would be great to have all these changes landed in 3.0, I agree that merging this PR will be tough regardless of when we do this, so...

I can do those test in this PR as well, I was considering doing it in separate PR. At least deprecation can happen here

Nope, I thought It would break the API. then you need to add `async` keyword to `sendTX` and `await this.broadcast`

When it returned Promise, it would work with other `async/await`. This will just break.

I am not sure if you have tried to configure jsconfig or something like that, I am not familiar with VSCode much. But after couple of experiments I think I...

I think you have `tsconfig.json` instead of `jsconfig.json`, that could be the issue ? and you are working with `js` file instead of `ts`

@braydonf Can you update all other dependencies as well ? Current deps are not compatible with `node-12`.

String does not get written to the database, `account` is. Actually `Path` is being written.