Zixuan Liu

Results 286 comments of Zixuan Liu

@lhotari Your review result has been fixed.

@StevenLuMT @zymap In the current implementation, all metadata is first extracted and stored in a map before performing a full GC pass over the entire dataset. This approach can result...

> This is a breaking change that modifies the package name and interface name. A breaking change that we add new method to the `Backoff` interface, not change package name....

@ivan-penchev I noticed this PR doesn't add a test, could you add a test for the producer and consumer with this logger?

> 1. Where should I place the test? You can write a test in the `pulsar/client_impl_with_slog_test.go`. > 2. What should I be testing? (that producer and consumer do not throw...