bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

fix: permission denied in the docker image

Open nodece opened this issue 1 year ago • 4 comments

Fix #4461

Motivation

$BK_USER has been added to the image, we should use this user to run the image.

You can try this command to verify this PR.

gh pr checkout 4464
cd docker
docker build -t zixuan/bk .
docker run -it --rm zixuan/bk

Changes

  • Use $BK_USER with the group root to run the image.
  • Follow up "Principle of least privilege".
  • Add ZK_SHELL_HOME to set the zk-shell home to writing .zk-shell file to BK_HOME/data, not BK_HOME.

nodece avatar Jul 15 '24 10:07 nodece

Could you help to review this PR? @shoothzj

nodece avatar Jul 15 '24 10:07 nodece

Bump

nodece avatar Jul 24 '24 01:07 nodece

@lhotari Would you please take a look again?

hezhangjian avatar Aug 16 '24 08:08 hezhangjian

@lhotari Your review result has been fixed.

nodece avatar Aug 22 '24 17:08 nodece