Margret Riegert
Margret Riegert
Ah alright. Investigating this more, it looks like the sanitize method currently sanitizes any HTML passed into the docs, but not any HTML generated by the markdown parser itself (such...
Ah my bad. By "HTML generated by the markdown parser" I meant anything generated by the template itself. As it stands now it sanitizes anything from doc comments, while not...
Is there anything else that needs to happen with this PR for it to be merged?
I think this could possibly be implemented in this way: - Have the docs generator find all links in the markdown - Select links that point to files in the...
That makes sense and works for me. So the process would be this, right? - Have the docs generator find all links in the markdown - Select links that point...
@Sija I can definitely see that and agree, and think it would be good do define/implement a more consistent doc format similar to what's done with exdoc. Copying images from...
It would also be useful if `crystal tool format` worked with ECR's as well, just for verifying the syntax / grammar of the file
@hugopl I think going with what exdoc or yard do may be better, as having plain markdown would also allow viewing from github/etc, and would be easier to implement.
@straight-shoota I think that's cool and may work well, though I'm not sure it's the best solution as it requires any docs need to be passed in via the AST,...
It's not source code, and I think the implementation could be a lot easier (and it easier for people to use/figure out how to use it) if it were via...