Margret Riegert
Margret Riegert
After doing some investigation and testing, the only additional code necessary for (1) is adding this to the MarkdDocRenderer, which just override the HTMLRenderer methods but adding escapes: ```crystal def...
That's fair, that may not be the best solution then. It was just a way of both making the default case safe but allowing for unescaped html if necessary. I...
Sanitizing may work on the output, we'd just have to be extremely careful in terms of what we allow through. It wouldn't stop someone from breaking documentation generation though (intentionally...
Including sanitize works really well, just needed to replace `escape` with a new `sanitize` method. I'm unfamiliar with the sanitization methods for your sanitize library so I stuck with common,...
I would be happy to. Thank you!
Don't we already use/link against libxml2 for XML? https://github.com/crystal-lang/crystal/blob/453a1591f7175aba81871b80411324929bd96cd5/NOTICE.md?plain=1#L34 https://github.com/crystal-lang/crystal/blob/453a1591f7175aba81871b80411324929bd96cd5/src/xml/libxml2.cr#L7 How do we already handle it currently with the XML::Reader and such?
Personally, I don't have a problem with just requiring access to libxml2, but can understand that not being the most ideal solution. > - Make the dependency optional (flag -Dwithout_libxml2)...
I think this could work well if combined with #13184 if the C Lib stuff is put in a separate tab.
> The latest version available on brew is the 2.4.2. This game requires 2.5 so you will have to download sfml from their website. > > After doing that I...
@lateralpunk What path are you talking about? As I do not have anything remotely similar on my computer. > I found a temporary fix. in build/src/CmakeFiles/MarbleMarcerSources.dir/flags.make, manually type the include...