Noam Zaks comments

Results 8 comments of


                                            Noam Zaks

Fix graph updater to respect vertex boundaries

I'm guessing the file `tests/test_graphical_units/control_data/threed/MovingVertices.npz` needs to be replaced accordingly, but how does one create the appropriate `.npz`?

Fix graph updater to respect vertex boundaries

> > [...] but how does one create the appropriate .npz? > > Please refer to the contribution guide [here](https://docs.manim.community/en/stable/contributing.html) in the AddingTests section. > > First check if the...

Fix graph updater to respect vertex boundaries

It seems this change, accounting for the vertices' radiuses, looks worse in 3D scenes. Perhaps there is an underlying issue with `get_boundary_point`. Here's the 3D scene from the test, with...

`self.play(Create(G))` connects edges to the centre of vertices unlike `self.add(G)` for Graphs

Hi. Sorry, not yet. I'll try again today. I tried to create the supposed npz result and compare the framed, but without success

`self.play(Create(G))` connects edges to the centre of vertices unlike `self.add(G)` for Graphs

Hey, small update; I found out some "workaround", but if you need this for something right now, you can try to use my WIP fix and make sure it looks...

Inline math fragments are reversed while text is set to an RTL language

Does it even make sense to have a multi-line inline equation in RTL? (And not keep them as blocks for RTL) As far as I know, all equations are LTR...

error: input file not found (searched at file.typ)

Hey, I wasn't able to reproduce this issue. Can you run `ls` before `typst compile file.typ`? That should include a file named `file.typ`.

Add Read The Docs

> This is really good. Ayal Zaks and I discuss who tough we are on code review, but I'm having difficulty finding even a suggestion for an improvement. Thanks 😊...