Noah Falk
Noah Falk
Cool! I've got this flagged to come and take a closer look but it might be a little bit.
Thanks for putting this together! A couple thoughts here: - For the timestamping issue, this sounds like something we'd want to firm up prior to doing major work. I think...
> @noahfalk, my idea here is to add DateTime.UtcNow timestamp immediately to Tags (TState) for each buffered log record as a new key-value pair with the Timestamp key. Then log...
Definitely feels like an improvement over the earlier iteration :) Some more questions to keep refining the design: ### buffering Are you envisioning that users pick exactly one buffering option...
> I updated the post directly, hopefully it is ok with you. Yep! > > Its unclear how the GlobalBufferingOptions are currently fitting in. Maybe this was just part of...
Yeah, I think that is correct. OpenTelemetry requested we add this extra IsRemote bit to ActivityContext that is intended to indicate whether an ID originated from a remote machine across...
It fails when the format of traceParent doesn't match the W3C spec (code here: https://source.dot.net/#System.Diagnostics.DiagnosticSource/System/Diagnostics/ActivityContext.cs,70) > If it does, should we be passing traceParent to CreateActivity instread of parentContext? There...
@JamesNK (Just fyi - This looks like a minor cosmetic change)
> If we need some advanced, precise things, they should come as an addition to basic CPU/mem/GC things. Let's focus on basics first. Are you suggesting lets review some things...