Noah Falk
Noah Falk
Everything was addressed, PRs linked in the description.
PR #5354 addresses a timing issue that caused the test to fail with a SocketException saying the connection was refused. This occured because the test was racing calls to GetProcessInfo...
fyi @mikem8361 @hoyosjs @mikelle-rogers
Hey James, very sorry for the delay! I saw I had this flagged weeks ago and then it slipped off my radar. A couple questions I had reading over this:...
> The sign in manager handles different auth credentials. Do we expect non-token, non-password credentials to surface through these counters? The naming seemed fairly token and password specific.
> If we support more in the future then we'll add new counters as needed. Sounds just fine. Thanks James!
PTAL @dotnet/dotnet-diag
I just accepted Mitchell's suggestion but it reset the review gate. But if someone can accept again - yep ready to merge!
I don't think the behavior is expected. As for where the issue is - probably one of two places: - Something in the TplEventSource didn't log an event it needed...