no-sws

Results 9 comments of no-sws

Hi @mattoperry Still need to do some performance testing, but I've got a rough sketch of this going: https://github.com/Automattic/gutenberg-ramp/compare/master...no-sws:feature/wp-query-criteria Also, I have not looked into post meta caching yet (maybe...

@mattoperry That all sounded reasonable to me. I've updated my branch to use the `query` criteria key (instead of "merged" together at the top-level) (i.e., `$criteria['query']`). I've also "promoted" the...

@justnorris that sounds like a decent idea to me but I'll defer to @mattoperry . A couple things I was thinking about: - Similar to what @mattoperry suggested re: the...

Re: `$criteria['meta']`, I was thinking of something along the lines of: ``` diff --git a/inc/class-gutenberg-ramp.php b/inc/class-gutenberg-ramp.php index 7460543..97aa990 100644 --- a/inc/class-gutenberg-ramp.php +++ b/inc/class-gutenberg-ramp.php @@ -129,6 +129,12 @@ class Gutenberg_Ramp {...

@mattoperry I was not able to recreate this issue in 1.8 to confirm @jasonagnew's [comment](https://github.com/Automattic/liveblog/issues/477#issuecomment-395444177). The only rendering issue I could see was that _sometimes_ a page would not "fill...

Hi @mattoperry, I think [my comment](https://github.com/Automattic/liveblog/issues/478#issuecomment-396811674) on #478 might be helpful/relevant here. Let me know if I'm way off or if you need any more clarification. Thanks!

@mattoperry when testing something else I came across an issue that _kinda_ reminds me of this issue but might be different enough to warrant a new issue. To reproduce: 1....

I'm having trouble recreating this issue on `master` (v1.8) after manually testing the following scenarios: - As an editor, I created, updated, and then deleted a single entry. No JavaScript...

Hi @mattoperry, reading through the `CHANGELOG`, it looks like the major changes to patch these issues were incorporated in [1.7](https://github.com/Automattic/liveblog/blob/master/CHANGELOG.md#17). The [Milestone/1.7 - React Front-End PR](https://github.com/Automattic/liveblog/pull/322) seems to confirm this....