naoki kuroda

Results 8 comments of naoki kuroda

@shivamsouravjha thank you! I created the issue and apply your review!

How about implementing it this way? **Overview** Add an optional flag to `Git` in the following configuration to indicate whether or not to create a new branch. https://pipecd.dev/docs/user-guide/managing-piped/configuration-reference/#git **Details** -...

@sivchari @khanhtc1202 Thanks! I think it is better from a testing point of view to create a uuid-generator-client, but currently other parts of the program also directly use google/uuid methods,...

I created PR about this issue. https://github.com/pipe-cd/pipecd/pull/4395

[@khanhtc1202](https://caadtech.slack.com/team/U01FRBLEFU5) Thanks so much!!! > That's why I think we should move this configuration closed to event watcher related part I think so too. so, fix this in this commit...

> Also, the implementation at PR https://github.com/pipe-cd/pipecd/pull/4395 only commits the change in a new branch, I think we should make the merge request from that branch to the piped watching...

Also, In the current implementation of pipecd/pkg/git/repo.go, we can't do more than use git command ,for example git push, git commit. To create a pullrequest, I think we need to...

@khanhtc1202 Thank you so much!!! > Let's review and merge the current createPullRequest configuration (aka. https://github.com/pipe-cd/pipecd/pull/4395) first, then create a separate one for automatically creating pull requests, since we have...