Nat Mote

Results 93 comments of Nat Mote

I put up a PR to fix: https://github.com/tree-sitter/tree-sitter/pull/1836

It looks like this exposed some performance problems with Flow. I'll take another look and see if those perf problems still exist, and see what needs to be done from...

@FezVrasta, what performance improvement are you referring to?

Those are architectural improvements, and unlikely to help with specific pathological performance issues. I'll take another look at this sometime this week, but I'm not optimistic.

Earlier in this thread, @gabelevi described the performance problems that this used to lead to. My recollection is that they were still there when I took another look, and I...

This looks pretty reasonable. Again, I'd like to apologize for the long response time here. I'd like to see how this affects our main internal codebases. When you get a...

Don't worry about re-recording the tests, I can deal with that after I import.

Sorting out an issue... Feel free to review but don't merge yet.

Still meaning to get back to this... I got some failing tests in semgrep-proprietary when I pulled in this change and still need to investigate.