Nat Mote
Nat Mote
Can we discuss the default, then? Personally I would prefer 0 or 1 characters, and I would be hesitant to make the Flow autocomplete provider respect the setting because the...
I don't have solid data -- this is just guided by my own preferences. In my experience there are often only a handful of JavaScript object properties, and I like...
Following up on @alex-pinkus' comment in #177: > If we differentiated implicit vs explicit semicolons, would that maybe let us sidestep the problem (you could just avoid trying to match...
Now that implicit vs explicit semicolons are differentiated, it's pretty straightforward to work around this in Semgrep, so I'm closing
Sure, will do. This isn't ready for review yet by the way, that's why I have it marked as a draft. I just wanted to get the full CI running.
Thanks for the prompt and thorough review! I've responded inline and I'll go through and make the changes as soon as I can.
Thanks, both of you, for your thorough reviews! I believe that I have addressed your concerns by improving readability and explanations. Let me know what you think!
Just had to handle the new log line for autofix failure in the e2e test
I've responded to your comments and made some changes. Back to you for another round!
Could be, but it would only help if we are ready to take the plunge and try parsing with tree sitter *first*. pfff can parse this, it just parses it...