Naman Goel

Results 405 comments of Naman Goel

> fs.writeFileSync('dist/stylex.css', style); It looks like this will overwrite the CSS file for every JS file that is transformed. This will work as the styles are style being collected, but...

My opinion on this is that familiarity with the JS should be preferred in all cases. In this case, JS has no similar feature any way.

@zekesonxx Please elaborate a little.

# On semicolons: the typical example of bad ASI in javascript is: ``` return someValue ``` becoming: ``` return; someValue; ``` If these kind of problems can be avoided, then...

@nedjulius is correct. We do not want complex logic within dynamic style functions. Instead the values should be calculated within your component and the final style values should be passed...

Isn't this problem solved by ES6 modules syntax?

Maybe this is a feature for the cli rather than for syntax? ES6 module syntax can just be transpired into Cjs? Too many module syntax's = confusion.

I really think that a polyfill like Selectivzr as well as a ES5 shim should make Salvattore work in IE8. The polyfills would need to be loaded before salvattore though....