Nickolay Kolev comments

Results 4 comments of


                                            Nickolay Kolev

Paren-less multi-line method call indentation is wrong

I just ran into this as well. It seems parenthesis around parameters do not make a difference. Current erm indents multi-line parameter lists like this: ```ruby foo(1, 2, 3, 4)...

Handling arrays of custom types

Thanks for looking into this. I looked at the `FromField` instance of `PGArray` and I think I understand neither enough of the Haskell nor enough of the PostgreSQL part to...

Allow select: map(x, fields), select_merge: %{} as source query for insert_all. Fixes #4430

@greg-rychlewski I can see in https://github.com/elixir-ecto/ecto/blob/e0bb7299fe0540998aeb6b10e5b87b63f66f61cb/test/ecto/query/planner_test.exs#L2311 that there is a `fields` field on the `Ecto.Query.SelectExpr` struct. Would it be possible to use this field to extract the headers?

Support `select: map(x, fields), select_merge: %{...}` in source query for insert_all

> Please take a stab at it. It may be that making it work is just too complex, and then we could improve the error message, but we should definitely...