Naoki Mizukami
Naoki Mizukami
Hi Shervan, right now, we don't have any in control file. It may be reasonable to add water balance tolerance in control file. it is now hard-coded in [pulic_var.f90](https://github.com/ESCOMP/mizuRoute/blob/d435ec01ee3079bd0349951d7d3cb9462c0a1145/route/build/src/public_var.f90#L33) and...
Hi @ekluzek, Here is the draft on constituent transport within mizuRoute. If possible, I would be looking for coding design guidance so make it easy to implement more constituents the...
Some of changes to be done in future PR: For an array like array(0:1), 0 means previous time step and 1 means current time step. Replacing with magic numbers with...
Thanks Erik (@ekluzek) for the comments. I went through almost all the comments, and would like you to take a quick look, but not sure about what to do with...
[This line](https://github.com/ESCOMP/mizuRoute/blob/be8db1f8f70309ea1877645faaea43fbf8db1800/route/build/cpl/RtmMod.F90#L833) is rpointer file read. But, actually this has not been tested so far. so may need to look into why
Hi Erik, Yes, these change resolve rpointer issue.
Yes, these can be moved to `config.yml` under `key_metrics`. Looks like each component can have its unique parameters?
Hi Teagan (@TeaganKing), The notebook almost ran with `cupid-run -rof`. One error was reading geopackage file (gis vector data) via geopanda. You can see /glade/work/mizukami/CUPiD/examples/coupled_model/month_annual_flow.ipynb. cupid prints on screen this:...
Hi @TeaganKing, some hint is that I can ran outside cupid-run, meaning I can run the notebook manually on jupyterhub with `[conda-env:cupid-analysis]` env on, but NOT with `cupid-analysis` on (get...
I did the following steps to remove cupid-analysis env and reinstall it on terminal. ``` mamba remove --name cupid-analysis --all mamba env create -f environments/cupid-analysis.yml ``` It did not fix...