Nick Miyake

Would like to get some feedback on usability/API in addition to the underlying issue. The main trade-off I see is between keeping the API generic/raw versus making it more specialized....

I've put up an alternate implementation at https://github.com/palantir/witchcraft-go-server/pull/99. I think I may prefer that alternate approach as one that has better balance/trade-offs, but open to feedback.

Thanks for raising this issue! Took a look at the PR, and one thing to note is that, as currently implemented, I don't think that it makes the guarantee that...

You can add health/readiness/liveness sources either in the builder OR in the init function -- the `Router` field of the `witchcraft.InitInfo` struct passed to the initialization function implements `ConfigurableRouter`, so...

Taking a look at the broader PR now -- will focus on high-level feedback rather than exact code content (can review content once we ensure that we have agreement on...

OK yeah I'm not opposed to exposing this, and don't have major concerns since this doesn't introduce any new dependencies. The one thing that I still find a bit strange...

Thought about this further after our in-person discussion. I think the decision here stems on how opinionated we want to be in terms of how we deal with configuration. As...

Concretely, if there's some function like `structfields.SetToDefaults` (analogous to https://github.com/creasty/defaults), then the approaches described above would be: ```go WithConfigUnmarshalFunction(func(data []byte, v interface{}) error { if err := structfields.SetToDefaults(v); err !=...

Yes, although this is working as documented, agree that it's unintuitive given the starting parameters. If the default value isn't a concrete value, I feel like `0` (no default limit)...

Yeah it's hard to say for sure because Mateusz isn't around, but I believe the intent of the default value for max backoff is that most "simple" calls probably don't...