Nick Miyake

Thanks for the PR! Most of the core `ptimports` code is based on `goimports` (https://github.com/golang/tools/blob/master/cmd/goimports/goimports.go). Is this an issue there as well, or does this issue only arise because `ptimports`...

There seem to be a few different things going on here. Here's my overview: * If `ptimports` doesn't run properly on Windows due to path or separator issues, that's definitely...

gödel issue referenced above is at https://github.com/palantir/godel/issues/269.

Thanks, content looks good! Underlying code has changed since your initial commit and conflicts now exist -- could you update this PR to fix the conflicts? Once that is done,...

Work involved would be the following: * Parse content of the `version-var` configuration to determine the package path and variable * Fail/error if format is not correct * Load the...

* The candidates would be 1.1.0 or 2.0.0, right? I'm fine with either one. * Release notes should also mention changes caused by #56 and #67, which changed both algorithms...

Should the version be 2.0? Otherwise, we will be in a case where values written by 1.1.0 can't be read by 1.0.0, which seems counter-intuitive (although not sure if it's...

Note that, currently, the Java-generated server for this service will not start due to https://github.com/palantir/conjure-java/issues/68. However, the client can be tested against a plain/test server to verify this behavior.

Thanks for the feedback. Just for clarification, is it the case that the current `Close()` and `Shutdown(context.Context)` functions do close/shut down the server, but cause the start function to just...

Got it. Yes, I think this is reasonable -- would just say that, in the comment/documentation for the function, you should note that the function is the equivalent of calling...