nmigen-issue-migration

**Comment by [mithro](https://github.com/mithro)** _Tuesday Jul 09, 2019 at 00:53 GMT_ ---- I would suggest that the; * `Resource` object have an optional attribute called `silkscreen_reference` which takes an arbitrary string....

**Comment by [whitequark](https://github.com/whitequark)** _Tuesday Jul 09, 2019 at 02:46 GMT_ ---- What is `m.define`?

**Comment by [mithro](https://github.com/mithro)** _Tuesday Jul 09, 2019 at 02:58 GMT_ ---- Was thinking something like `add_constant` ```python class BaseSoC(SoCSDRAM): def __init__(self, platform, **kwargs): self.add_constant("SPIFLASH_PAGE_SIZE", platform.spiflash_page_size) self.add_constant("SPIFLASH_SECTOR_SIZE", platform.spiflash_sector_size) ```

**Comment by [whitequark](https://github.com/whitequark)** _Tuesday Jul 09, 2019 at 03:03 GMT_ ---- That doesn't explain what it does.

**Comment by [mithro](https://github.com/mithro)** _Tuesday Jul 09, 2019 at 03:05 GMT_ ---- Provides a define in the C header file. CSRConstant could be another option. Or you could write out a...

**Comment by [whitequark](https://github.com/whitequark)** _Tuesday Jul 09, 2019 at 03:38 GMT_ ---- Writing C header files is definitely not something that should be a part of core nMigen.

**Comment by [mithro](https://github.com/mithro)** _Tuesday Jul 09, 2019 at 03:47 GMT_ ---- I agree that the output side probably doesn't make sense in nMigen's core -- was just trying to provide...

**Comment by [whitequark](https://github.com/whitequark)** _Tuesday Jul 09, 2019 at 03:54 GMT_ ---- We should definitely have the ability to add refres information to resources. Perhaps `Resource(..., Refdes("U3"))`? Or maybe `Silk("U3")`. I...

**Comment by [mithro](https://github.com/mithro)** _Tuesday Jul 09, 2019 at 04:10 GMT_ ---- I like Silk over Refdes (I assume **Ref**erence **Des**ignator)? Something like a freeform `__doc__`, `help` or `doc` would be...

**Comment by [whitequark](https://github.com/whitequark)** _Tuesday Jul 09, 2019 at 04:15 GMT_ ---- > Something like a freeform `__doc__`, `help` or `doc` would be a good thing to have? Python docstrings are...