Nick McKinney

Results 40 issues of Nick McKinney

Test case below -- `RemoveRedundantDependencyVersions` only touches a dependency if it has exactly the same scope as the managed dependency, but in actuality, there are valid cases where the scopes...

bug

Consider a Maven settings.xml which uses property resolution for credentials: ```xml my-organization-repository ${MAVEN_USERNAME} ${MAVEN_PASSWORD} ``` And, suppose those properties are not resolved at runtime (eg the environment does not have...

bug

See `org.springframework.boot:spring-boot-starter-actuator:2.5.14` for an example. If you run `ExcludeDependency` for `org.junit.vintage:junit-vintage-engine` on a project with the above actuator dependency, as the JUnit4To5 recipe does, then it adds this junit exclusion...

bug

As discussed w/ @jkschneider on slack, consider a test case like this: ```kotlin @Test fun `does not reformat properties outside the affected key`() = rewriteRun({ spec -> spec.recipe(ChangePropertyKey("a.b.c", "x.y.z", true,...

bug

See test case (for a YamlParserTest impl): ```kotlin @Test fun scalarValueWithQuotedDoubleBackslashEscape() = assertRoundTrip(""" escaped-slashes: "\\." """) // fails; actual below: //escaped-slashes: "\." ```

bug

## What problem are you trying to solve? Suppose you want to add a dependency to a Maven project, but only if some other condition is true in the `pom.xml`....

enhancement

## What problem are you trying to solve? Declarative preconditions currently associate via `AND` if you declare multiple on the same recipe. If you want to achieve an `OR` relationship,...

enhancement
question

## What problem are you trying to solve? Like dependencies, plugins can also have redundant versions when compared to the `pluginManagement`. But, `RemoveRedundantDependencyVersions` only touches dependencies. ## What precondition(s) should...

enhancement
recipe

Eg `{.md,.txt}`, like `HasSourcePath` used to support _Originally mentioned by @timtebeek in https://github.com/openrewrite/rewrite/issues/3755#issuecomment-1838623921_

enhancement

test case: ```java @Test void releaseVersion() { rewriteRun( pomXml(""" 4.0.0 org.springframework.boot spring-boot-starter-parent RELEASE bogus.example arti 0.0.0 pom """) ); } ``` This syntax is not nearly as prevalent as its...

enhancement
design-partner-3
P3