Niko Aarnio

Results 31 comments of Niko Aarnio

Initially we implemented private functions for all tools, but this aspect our style guide has loosened to the point where it is not required anymore. I personally started shifting towards...

No worries. I was aware that they can be performed with the existing transformations functions, but I thought it a good idea to create public functions that are called `normalization`...

Hi @msmiyels , I am revisiting this now. So I agree that a good way to implement for example `normalize` is to just create a wrapper around `min-max` and enforce...

Should we add this to the toolkit under category such as `experimental` or similar? That could be a compromise solution that considers limitations/weak applicability of the method in MPM but...

Closing this PR now since it seems we do not intend to include this tool, at least for now.

@jtpesone and @chudasama-bijal , have you had time to look at this and #355 ? I am busy with other EIS issues and would like to avoid having to wrap...

Okay thanks @chudasama-bijal , then I'll proceed to merge this!

@nialov any ideas or opinions on these?

Thanks for the comments! > Personally I would keep all the similar command-line functions in cli.py so they are all easy to find. You could maybe add an e.g. cli_utilities.py...

Tagging you here @em-t in case you want to grab this. While implementing the CLI function, the toolkit function implementation should be checked if it's OK. I'm not sure for...