eis_toolkit icon indicating copy to clipboard operation
eis_toolkit copied to clipboard

338 agterberg cheng ci test

Open em-t opened this issue 11 months ago • 1 comments

Resolves issue #338

I opened this as a draft at this point, since I would like some feedback before finalizing things.

Is it doing what it's supposed to? 😄

Are there any other CI tests to include? (Eg. the sources listed in the issue mention chi-squared test and the Kolmogorov-Smirnov test. Chi-squared is already included in the toolkit, but I don't know how well it integrates with the data types used by the WofE functions, and I didn't look into the latter at all.)

What would be a useful output from the function?

em-t avatar Mar 07 '24 12:03 em-t

@jtpesone and @chudasama-bijal , have you had time to look at this and #355 ? I am busy with other EIS issues and would like to avoid having to wrap up these Wofe issues.

nmaarnio avatar Apr 08 '24 10:04 nmaarnio

At this stage it should be sufficient to provide the Agterberg-Cheng CI test, implementation seems good to go.

chudasama-bijal avatar Oct 23 '24 05:10 chudasama-bijal

Okay thanks @chudasama-bijal , then I'll proceed to merge this!

nmaarnio avatar Oct 23 '24 07:10 nmaarnio