Niels Lohmann

Results 421 comments of Niels Lohmann

That assertion held true so far. If that changes now, this may indicate a breaking change.

> IMO, we can add notes in documents to tell people that they should not use `std::optional(j_null)` directly if it still raise an exception. I do not like this approach....

Same question as with #2117 - how to proceed here?

@karzhenkov Can you please update to the latest develop branch?

Don't worry about Codacity - there is also another test failing: `ci_single_binaries` fails, because header `optional.hpp` is not self-contained and seems not to include ``.

Oh, I had to make some changes to the CI. See #2981. I will merge this soon. Sorry for this!

Done. Please update your branch. This should fix the CI error.

FYI: I suppressed the warnings for non-explicit constructors in Codacy.

> Would it make sense extending this to have an optional _default_ value? > > I am in the process of porting over a project from jsoncpp to nlohmann-json, and...

It is currently on hold from my side. It's definitely a nice idea for the format, but I currently don't find the time to push this further.