Niels Lohmann comments

Results 421 comments of


                                            Niels Lohmann

Add conversion from/to std::optional

Since I don't use MSVC myself, I cannot debug this further. I will drop this feature from 3.8.0 to proceed. Feel free to dig in, but I will not pursue...

Add conversion from/to std::optional

@kix-mcotton Thanks for reporting! I updated the branch to the latest develop version and will give it another try.

Add conversion from/to std::optional

Two tests at AppVeyor are still failing. :-/

Add conversion from/to std::optional

Wow, thanks for the detailed analysis! What do you propose to do?

Add conversion from/to std::optional

> Maybe it is reasonable to support std::optional only with JSON_USE_IMPLICIT_CONVERSIONS defined as 0 for a while. Yes, I think this is a reasonable approach.

Add conversion from/to std::optional

I'm not sure how to proceed with this PR. Any ideas?

pkgconfig integration wrongly rendered if tests are run

Thanks for reporting. Maybe @doronbehar @eli-schwartz @xvitaly @ericonr who worked on pkg-config related PRs in the past can help here.

pkgconfig integration wrongly rendered if tests are run

I also have little experience with pkg-config and only use CMake in this project to serve my needs (i.e., compile and execute the tests).

How to save mutation code?

This is currently not possible, but PRs welcome!

Database was not Created

Did you follow the installation instructions (https://github.com/nlohmann/mutate_cpp#installation)? What OS are you using?