Niels Lohmann comments

Results 421 comments of


                                            Niels Lohmann

`<exception>`: constructor does not copy what_arg if `_HAS_EXCEPTIONS=0`

Thanks for the quick response! About the non-standard issue: I think it's not about the constructor of `std::exception`, but rather about the behavior of the derived classes like `runtime_error(const char*...

#4271: Use OS independent utf8 string representation of std_fs::path at to_j…

Please run `make amalgamate` with Astyle (http://astyle.sourceforge.net) 3.1 installed.

#4271: Use OS independent utf8 string representation of std_fs::path at to_j…

The exception could come from the conversion of `std::u8string` to JSON. As `std::u8string` is not supported, the string is treated like a sequence of bytes and converted to an array.

Inconsisten operator[]

The behavior is documented here: https://json.nlohmann.me/features/element_access/unchecked_access/ You may consider it inconsistent, but it is the same since version 1.0.0 of the library. Changing it now would break existing code which...

Isn't the time complexity a little high, when `for (auto x : m) { ... }`?

Thanks for reporting. This project is currently unmaintained in favor of https://github.com/nlohmann/json/blob/develop/include/nlohmann/ordered_map.hpp which has the same functionality.

Add missing #includes based on C++ language server.

I am also hesitant: it seems to fix a problem we don't have.

Add missing #includes based on C++ language server.

Can you please rebase to the develop branch? I'll check this then.

json_pointer - a code example from doc's does not compile

I can confirm the issue.

docs: Add FAQ reminder to bug report template

It was closed before I had the chance.

Reference tuple from json

🥳 Green CI! I will try to review this in the next week.