Niels Lohmann comments

Results 421 comments of


                                            Niels Lohmann

nlohman::ordered_json using deprecated operators on calls to .value and .at with join_pointers

PTAL #4791

Fix ~basic_json causing std::terminate

> @nlohmann I'm having trouble making the Windows build correct. I don't have windows machine available to debug/diagnose. I don't use Windows myself. :-/

Fix ~basic_json causing std::terminate

I am not sure what to make of this right now. The noexcept annotation was from times where we did hardly anything in the destructor.

tests: Mark the tests that don't need to downoad test files with the …

From the README: > Note that during the `ctest` stage, several JSON test files are downloaded from an [external repository](https://github.com/nlohmann/json_test_data). If policies forbid downloading artifacts during testing, you can download...

tests: Mark the tests that don't need to downoad test files with the …

Can you check if JSON_TestDataDirectory works for you?

tests: Mark the tests that don't need to downoad test files with the …

> 1. why is this test data on different repo? > (I presume due to $SIZE) Exactly.

compiler error using clang-16.0.5 when using gcc-13.1 standard library

We use GCC 13.3.0 in the CI. Can you please re-test with the latest develop branch?

compiler error using clang-16.0.5 when using gcc-13.1 standard library

Sorry, I missed the point about mixing Clang with GCC's STL. We do check Clang with both libc++ and libstdc++, but only for the latest Clang version (20.0.0). I'm not...

inconsistency with string/string_view lookups

I can confirm an error at: ``` error: no viable overloaded operator[] for type 'json' (aka 'basic_json') 25 | std::cout

inconsistency with string/string_view lookups

Sure, why not.