nlisker

Results 233 comments of nlisker

Not sure what jcheck wants. It's complaining about empty spaces that have a `}` appear after them. This is the error: https://github.com/openjdk/jfx/pull/1387/files#annotation_19798318258.

Looks like the line specified by jcheck was off.

Thanks, I'll try it out. Maybe @abhinayagarwal can use this info to create a fix.

No, the licensing issue is what I'm personally worried about here since the FBX format is proprietary. The technical side has become easier now with JDK 22 where the FFM...

A google search shows that such attempts have been made already, like in https://github.com/NekoLvds/GLTFImporter and https://github.com/javagl/JglTF. The difficulty in importers is managing the conversion between the format's data types and...

The manual test app path has been changed to https://github.com/openjdk/jfx/tree/master/tests/performance/3DLighting/src/main/java/attenuation. `DirectionalLight` has also been added since.

This is what I would expect, so looks good. Where is this mentioned to the user?

I think the CSR needs updating.

John and I discussed this off-list. I will write a short review of this change. ### Behavior The solution implements has the following behaviors, which are compared to the current...