Nicolas Lenepveu
Nicolas Lenepveu
> I feel like the `preserveSharedColumn` option is unnecessary and overcomplicates the implementation. > > Couldn't we just make TypeORM respect manually configured column names? i.e. the renaming of columns...
I agree the breaking change shouldn’t be a big deal to fix. Users can always explicitly rename the column themselves in the join table definition. So this feels manageable even...
I’m fine to drop the `preserveSharedColumn` option and rework the PR accordingly. I’ll update the PR to: - Remove the `preserveSharedColumn` option. - Adjust the implementation so explicitly set column...
> _Later edit:_ [8934e27](https://github.com/typeorm/typeorm/commit/8934e27dc412a90f8ef5b80aac19ebc86d59c054) introduced `changeDuplicatedColumnNames`. But why? Looking at the example, it seems this was added to support using `@JoinTable()` without options in self-referencing entities (looks like a graph-like...
@sgarner @alumni I’ve updated the PR based on the discussion to ensure explicitly set column names are always respected. This should now align with the intended direction. Let me know...
> Can you rebase this PR with the current master branch please? Done!