Noah Lopez

Results 12 comments of Noah Lopez

Yes, that was a concern I had after creating the commit. I can definitely make adjustments to the change reflecting what you suggested. I'll get that done when I have...

Hello! I submitted this update to the PR almost a week ago and I'm not sure what the next steps are for Rock. I did notice this page in the...

![Screen Shot 2022-07-19 at 4 16 16 PM](https://user-images.githubusercontent.com/85907597/179863826-3aa1cadd-58fd-45f5-b295-e622a718e3f4.png) On further examination, it looks like the attribute value does save; however, it gets saved with EntityId = 0. So it saves...

A temporary fix on our side was to recreate the Registration Template so that we get new FormField Ids. It took three attempts because we kept colliding with some ValueFilter...

> @nlBayside Do you have a little more of the StackTrace and exception info? It sounds like you are getting a Null Value Exception, but I don't see that in...

I think this should be reopened again because the FieldVisibilityWrapper class is also used for Workflow Action Form Attributes. The changes here work for Registration Template Forms, but disregard Workflow...

I am reopening this (https://github.com/SparkDevNetwork/Rock/issues/5181) because no work was actually done. I was asked a question, and then 19 minutes later the issue was closed. That is not sufficient time...

This issue was discovered _in_ a third party block, but that block does not differ from the core one in the lines provided. The fact that we're using a third...

I ran into another problem from the RegistrationEntry block that at first I thought would be this one, but the exception is slightly different. It still hits the ```ApplyFieldVisibilityRules()``` method,...

I saw this issue had a Pull Request accepted about two weeks ago (https://github.com/SparkDevNetwork/Rock/issues/5181) and I left some concerns regarding this fix's implementation. I wasn't sure if the Rock Demo...