Ni Kaixiang

Results 16 comments of Ni Kaixiang

In principle it is always possible to describe a series of files with one single pattern. In the case "/data/R00001_*_tags.root\n/data/R00002_*_tags.root", it is equivalent with "/data/R0000[1-2]_*_tags.root". But it's still OK to...

If I remember correctly you cannot write the implementation of the template methods separately in the cxx file, unless you `#include` this cxx file like a .h file. I don't...

It's OK to put PandaX-III logo in README. We use same logo as PandaX collaboration, which is: ![logo](https://user-images.githubusercontent.com/14999274/205415285-ae760d54-e403-4ae2-9599-d7c55df0e480.png)

> I don't think making it compatible with c++11 is moving backward. I did not revert the code. I am just adding the traditional solutions with `dirent.h` in case no...

> but we have to draw the line at some point, why not go older than C++11? If some user raises the issue of not being able to install REST...

> However in practise most users of REST also want to install the libraries and packages (especially Geant4), so even though Geant4 is not technically a requirement I think since...

If returned, the global variables REST_COMMIT/REST_PATH/REST_USER are not set. It will make REST behave differently. I think we should set these variables manually before early return under testing condition. ```...

I am not familiar with ctest. Seems that we can input c++ definitions to the code during the test. Then maybe it is also possible to do something like: ```...

> I am not sure if I follow. The early return is a dirty fix I made in order to avoid tests failing, I think it should be possible to...

> > > I am not sure if I follow. The early return is a dirty fix I made in order to avoid tests failing, I think it should be...