Nikita Kryuchkov comments

Results 15 comments of


                                            Nikita Kryuchkov

Don't check round change messages for duplicated full data

> maybe some unit tests should be included or changed? done

Don't check round change messages for duplicated full data

> @nkryuchkov @MatheusFranco99 @moshe-blox > > Is this also part of new message validation? I think we should bring this in to genesis and new impls. As I remember it...

Message validation estimated round checks

I tested this PR and while performance looked good, I saw significant amount of messages violating estimated round rules. Their timestamp looked like the rule was applied correctly, but the...

No reason to silence wrong domain ignore error

@y0sher As I remember you said we need to keep the wrong domain error silenced temporarily due to some change in domains. The plans haven't changed, have they?

Use partial signature messages instead of decided in exporter

The explorer team shared the fields they are using, so this PR needs to check whether all these fields are set in the old 'compatibiliy' API: ``` public key slot...