ssv icon indicating copy to clipboard operation
ssv copied to clipboard

Published 20 hours ago • verified publisher icon ssvlabs

Don't check round change messages for duplicated full data

Open nkryuchkov opened this issue 1 year ago • 1 comments

This PR fixes a case when node receives proposal or decided messages in round 2 and compares them with full data of round change messages for round 2, resulting in a validation error because full data differs.

Changes:

  • Don't check round change messages for duplicated full data

nkryuchkov avatar Jan 08 '24 10:01 nkryuchkov

maybe some unit tests should be included or changed?

done

nkryuchkov avatar Jan 08 '24 12:01 nkryuchkov

@nkryuchkov @MatheusFranco99 @moshe-blox Is this also part of new message validation? I think we should bring this in to genesis and new impls.

y0sher avatar Jul 15 '24 19:07 y0sher

@nkryuchkov @MatheusFranco99 @moshe-blox

Is this also part of new message validation? I think we should bring this in to genesis and new impls.

As I remember it was implemented in the new message validation. It would be nice to have in the old one, but its lifecycle will be shorter than this PR is opened

nkryuchkov avatar Jul 15 '24 19:07 nkryuchkov