Nic Klaassen

Results 15 comments of Nic Klaassen

@greedy52 I'm considering where to backport this. I don't see that https://github.com/gravitational/teleport/pull/10560 was backported anywhere, so I think it's only in v10. This change depends on that one in more...

@klizhentas Thanks for your review. If we will put the variables definitions in the role spec, I agree it makes sense to make them role-local only. I like the trait...

@klizhentas I have updated this RFD to focus on trait transforms now instead of the old role variables design. I will be OOO for the next ~week, if you get...

@klizhentas I like the idea of working with sets over lists. My current design with `filter` and the `override` map was mostly guided by an attempt to avoid multi-statement predicate...

> @nklaassen How hard would it be to add support for `lower` and `upper`? We've had a lot of requests for that functionality, see #5267. It's not hard at all...

friendly ping if you guys can review when you get a chance @gabrielcorado and @zmb3 it looks like the bot chose you for code review as well as docs review

I had an idea for a tweak to this design during the sync today which I think could handle SSO users better and be a bit easier for users to...

@hatched thanks. There's an average of ~1.5 per day, but the bigger concern is actually the peak number of PRs we try to merge right before a release, when it...

I got the same failure as Gavin on v14 https://github.com/gravitational/teleport/actions/runs/6422952356/job/17440476992

Another in the merge queue to master https://github.com/gravitational/teleport/actions/runs/7090182023/job/19296583245 ``` === RUN TestIntegrations/Discovery integration_test.go:4172: Error Trace: /__w/teleport/teleport/integration/integration_test.go:6155 /opt/go/src/runtime/asm_amd64.s:1650 Error: Expected value not to be nil. integration_test.go:4172: Error Trace: /__w/teleport/teleport/integration/integration_test.go:6151 /__w/teleport/teleport/integration/integration_test.go:4172 /__w/teleport/teleport/integration/integration_test.go:126...