teleport
teleport copied to clipboard
gravitational
Support China and GovCloud for database access
This PR adds support for non-default AWS partitions in resource ARNs of IAM policies and roles which are created for database access and auto-discovery on AWS.
I am hijacking this PR from https://github.com/gravitational/teleport/pull/13054 to add a minor fix and GovCloud support, and so I can more easily run CI and get this merged. The original PR was authored by @waylenguo, I will make sure he is credited as an author on the final commit.
@nklaassen See the table below for backport results.
| Branch | Result |
|---|---|
| branch/v10 | Create PR |
| branch/v8 | Failed |
| branch/v9 | Failed |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@greedy52 I'm considering where to backport this. I don't see that https://github.com/gravitational/teleport/pull/10560 was backported anywhere, so I think it's only in v10. This change depends on that one in more ways than one, do you think it's appropriate to only backport this to v10?
@nklaassen it wasn't backported because I wasn't confident of the change since we don't have an account to test. so it was kept on master.
I don't know if any users are explicitly asking for this support still and what versions they are. @r0mant @smallinsky?
Hey @greedy52, we did have a specific customer with interest in this. They are on 10.x.x and can easily update.
They are not currently being blocked because they have manually added DBs for now. They are on GovCloud.
