nkdengineer

Results 272 comments of nkdengineer

@parasharrajat I just resolved a few comments. Others should be resolved after we have the design.

- @dubielzyk-expensify Can you give me the radius and the background color code of the center button? Currently, the Crosshair.svg you supplied above is just: ![image](https://github.com/Expensify/App/assets/161821005/56f6fe52-1ae3-4b9f-97d8-88db967f2822) - Also, as you...

> There should be a mechanism to push the button on the map layer in a way that it does not overlap @parasharrajat I cannot find a way to do...

I am trying to implement your suggestion [here](https://github.com/Expensify/App/pull/40759#issuecomment-2074573778). It works well with the built-in control (MapboxDraw), but the custom react component

With the current code change, here is how it looks: - In native: https://github.com/Expensify/App/assets/161821005/a55a4b3e-57dd-466a-bd30-ae312f6b80dc - In web: https://github.com/Expensify/App/assets/161821005/5d8e1ce6-23f2-43c6-969d-c6659f8dd944

@dubielzyk-expensify I fixed your [comment](https://github.com/Expensify/App/pull/40759#issuecomment-2078500744). Here is what it looks like now: https://github.com/Expensify/App/assets/161821005/472cf068-a7f8-4d8a-8b1e-43ce2f9c58df

@parasharrajat Please help review PR when you have time. Thanks

@sonialiap Could you help to add the `High Priority` label to the issue, similar to [this case](https://github.com/Expensify/App/issues/40213#issuecomment-2093879555)? This was `HIGH` priority when the issue was opened, and only changed after...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Allow selecting a payer from the splits page ### What is the root cause...

@youssef-lr Do I need to update more detail in my proposal? I see that the implementation here https://github.com/Expensify/App/issues/40379#issue-2249250830 is detail enough.