nkdengineer comments

Results 272 comments of


                                            nkdengineer

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

@Beamanator I'd like to work on this.

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Sure.

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

### Update: - I'm looking into this with the provided logic, I'll finish and raise the PR tomorrow or Saturday.

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

@Beamanator I created a draft [here](https://github.com/Expensify/App/pull/52537). Please help test it with your local backend. Now I can only test with two rule approvers because it's marked as approved after the...

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

> It shouldn't be "the latest category approver", it should be the first by created date. @Beamanator I tested this case and `Category approver 1` is the first next approver

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Sure I will retest soon.

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

@Beamanator I tested with the staging server and we still don't archive the expected: Precondition: - A WS with a submitter, approver 1, approver 2, approver 3, approver4 - Enable...

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

@Beamanator Advance approve mode.

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

@Beamanator Ah checked my setting approval mode and in my reported case it's `BASIC`.

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Will re-test today.