Nikolay Karadzhov comments

Results 56 comments of


                                            Nikolay Karadzhov

fix(ts): xtrim threshold accepts string

Hi @Eomm, if you are still up to it, we can resurrect this PR and finish it

fix(ts): xtrim threshold accepts string

I guess thats fine. Thanks for the contribution!

fix(ts): xtrim threshold accepts string

@Eomm sorry, i clicked "merge" without looking. This is supposed to be merged agains `master`, not `v5`. Could you reopen against master?

`RedisClientType` type is slow to typecheck (TS performance issue)

@JulienZD thanks for flagging this out. Im not sure if we can easily fix this, but I will investigate

`RedisClientType` type is slow to typecheck (TS performance issue)

Hi all, really sorry about this! We are working to resolve this. Its complicated and will most likely result in a breaking change.

`RedisClientType` type is slow to typecheck (TS performance issue)

Hi everyone, thanks to @PavelPashov, we now have a mitigation for this issue. It reduces time/memory for compilation around x4 on my machine. We have put that fix in [the...

fix: #2522 max call stack size exceeded on MSET function

Closing this as the issue seems to be fixed in version 5

Reconnect Strategy doesn't work if connection is lost

@edrose I dont see the issue here. Even though `this.#connect().catch(() => {}))` swallows the error, #connect will still emit an `error` event, which will in turn trigger `#onSocketError`, continuing in...

Reconnect Strategy doesn't work if connection is lost

@edrose AFAIK the only thing that controls when the library will choose to stop retrying is the reconnectStrategy, which is controlled by the user. So, you have to return `false`...

Reconnect Strategy doesn't work if connection is lost

@edrose what do you think?