Results 984 comments of Nathaniel J. Smith

Something I don't currently understand at all: how does early data interact with ALPN negotiation? The issue is: the client sends early data before it actually knows which protocol the...

It looks like nginx and haproxy are both shipping early data support for http already, so I guess to answer these questions we need to study what they actually do.

Yeah, it's possible we'll want to make different decisions in a lower-level API. I'm not 100% sure it will make sense though. A low-level API doesn't have to be as...

Looks like it's just our fragile tests failing due to irrelevant changes in sphinx's output again. It would be nice if we had a better way to test the rendered...

@webknjaz Yeah, that action is great for normal workflows. Unfortunately there are a bunch of weird limitations that the hack described above is working around – and one of them...

> This suggests that repository_dispatch must supply type: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#external-events-repository_dispatch > So it may work with the types: filtering: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#onevent_nametypes Yes, that would make sense, but the docs explicitly claim that...

looks like the relevant bit is: ``` failed check 'await foo' failed test_content '\nNote\n\n\nawait foo(bar)\n\n\n\n\n' ``` Probably a change in sphinx upstream that our test is overly sensitive to, but...

Ah yeah, looks like dependabot found the same issue here: https://github.com/python-trio/sphinxcontrib-trio/pull/256

I don't have much in the way of conclusions here myself; I haven't played with type hints yet. sphinxcontrib-trio obviously needs a better story for handling them, since they're trying...

It looks like there are some standalone extensions for making type hint information more readable: * https://github.com/agronholm/sphinx-autodoc-typehints * https://github.com/nicolashainaux/sphinx-autodoc-annotation I don't know what the difference between them is (if any)....